Fix of tests for console commands for pending PR. #1353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pending PR #1351 needs to test some of the console commands to cover all methods in
\App\Images
as certain methods are only invoked by those commands. (For example, only the commandlychee:generate_thumbs
checks for the existence of size variants.)When I tried to write test cases for the console commands, I noticed that
...Test
.Mockery
was missing which is required to mock and capture the console output of the commandsThis PR repairs all that in order to keep it out of PR #1351. Also note that I have already split the existing tests for console command into three files, because the tests for the command
lychee:generate_thumbs
andlychee:takedate
will significantly be increased by PR #1351 and hence the deserve their own files already.